search

withastro / language-tools

Language tools for Astro
MIT License
268 stars 53 forks source link

🐛 BUG: `astro check` does not support TSC project references #920

Open codethief opened 3 months ago

codethief commented 3 months ago

Describe the Bug

This is a follow-up to my message here.

Passing a "solution-style" tsconfig.json to astro check, which references other projects (tsconfigs), will make the type checker silently accept type errors associated with types imported from those other projects.

The issue might be related to https://github.com/withastro/language-tools/issues/649 since project references rely on emitting type declarations.

Steps to Reproduce

(This is a placeholder ticket for now; I will update it soon with example code to reproduce the issue.)

See https://github.com/codethief/tsconfig-playground/tree/fe78e51d4f4c62f801f281efd1ffff48ecdb32ea/2024-07-27-astro-with-project-references

github-actions[bot] commented 3 months ago

Hello @codethief. Please provide a minimal reproduction using a GitHub repository or at least sharing the file where the issue happen. Issues marked with needs repro will be closed if they have no activity within 3 days.

codethief commented 3 months ago

@Princesseuh I added a minimal reproduction, see above.