search

withastro / language-tools

Language tools for Astro
MIT License
272 stars 54 forks source link

refactor(language-server): unused resolveLanguageServiceHost hook #953

Closed johnsoncodehk closed 2 months ago

johnsoncodehk commented 2 months ago

Changes

resolveLanguageServiceHost hook is a bad abstraction. Its problem is that the hook logic cannot be universal to TS plugin. We plan to deprecate resolveLanguageServiceHost hook in Volar 2.5 and migrate to a more reasonable setup hook in this PR. setup hooks are also available for TS plugins, but PR did not implement this in order not to change the old behavior.

Testing

Docs

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 85136caf9d6a48261985d5abe8552e61fd253f63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR