withastro / language-tools

Language tools for Astro
MIT License
272 stars 54 forks source link

feat: allow disabling handling updating files on file renames #961

Closed Princesseuh closed 1 month ago

Princesseuh commented 1 month ago

Changes

When using the Astro TypeScript plugin in addition to the language server, both will attempt to update imports whenever a file is renamed.

Both of them will handle it correctly individually, however if you run both in a row (pressing Yes or Always to the prompt in VS Code) the result will be corrupted, as editors who can handle multiple LSP renaming at the same time won't merge the results, they'll run them sequentially.

This PR adds a setting to disable the language server's handling of this, as more often than not, you want the TS plugin to handle it (so that it might handle additional formats from other plugins as well). This setting is disabled by default in VS Code, as the TS plugin is always included.

Fix https://github.com/withastro/language-tools/issues/896

Testing

Added tests

Docs

Apart from the setting description, N/A.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: f5e64e7fec4cfcd1f0c3cf793aec9023e2d20594

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------ | ----- | | @astrojs/language-server | Minor | | astro-vscode | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR