Create "Astro.url" & Deprecate "Astro.canonicalURL" - Githubissues

withastro / roadmap

Ideas, suggestions, and formal RFC proposals for the Astro project.

292 stars 29 forks source link

Create "Astro.url" & Deprecate "Astro.canonicalURL" #232

Closed FredKSchott closed 2 years ago

FredKSchott commented 2 years ago

Start Date: 2022-07-18
Status: Draft
Implementation PR: https://github.com/withastro/astro/pull/3959

Summary

Create a general-purpose Astro.url helper. Deprecate Astro.canonicalURL to use Astro.url instead.

// Before:
const currentPathname = new URL(Astro.request.url).pathname;
const canonicalURL = Astro.canonicalURL;

// After:
const currentPathname = Astro.url.pathname;
const canonicalURL = new URL(Astro.url.pathname, Astro.site);

Links

Full Rendered Proposal

FredKSchott commented 2 years ago

We're getting close to the Astro v1.0 RC, so would appreciate quick reviews from anyone reading, especially from @withastro/tsc. Thanks!