search

withastro / roadmap

Ideas, suggestions, and formal RFC proposals for the Astro project.
290 stars 29 forks source link

rfc: i18n routing domain support #798

Closed ematipico closed 3 months ago

ematipico commented 8 months ago

Rendered RFC

matthewp commented 7 months ago

In addition to the inline comments, one question I have is whether you have considered it makes sense to support domains and path prefixes at the same time. For example you might have domains for your most common locales but not for all of them. I'm not trying to blow up the scope, but would that be difficult to support (if it's even a good idea)? cc @delucis

ematipico commented 7 months ago

In addition to the inline comments, one question I have is whether you have considered it makes sense to support domains and path prefixes at the same time.

If the users use the utilities that we provide to create the URLs, we won't have problems with that.

Princesseuh commented 7 months ago

Matthew perfectly covered all the questions I had, so looking forward to the answers to his comments! Looks great, I'm excited to see this land in Astro, our i18n support is really starting to look quite complete, it's an awesome story.

matthewp commented 7 months ago

@ematipico

If the users use the utilities that we provide to create the URLs, we won't have problems with that.

So if this is supported, would that still fall under the routingStrategy: "domain"? If so could you maybe add this to the RFC and explain that it is supported.

ematipico commented 7 months ago

The commit cc268a6 (#798) adds some restrictions and clarifications based on everybody's feedback

ematipico commented 7 months ago

FYI, we won't need a new i18n.routing.strategy variant. I updated the implementation PR.

ematipico commented 3 months ago

Call for consensus starts now

matthewp commented 3 months ago

The final comment period has ended and this RFC is accepted! It can now be unflagged in Astro.