withastro / starlight

🌟 Build beautiful, accessible, high-performance documentation websites with Astro
https://starlight.astro.build
MIT License
5.03k stars 532 forks source link

Starlight Astro Github Pages docs url not working #2164

Closed windmillcode0 closed 3 months ago

windmillcode0 commented 3 months ago

What version of starlight are you using?

0.25.3

What version of astro are you using?

4.10.2

What package manager are you using?

npm

What operating system are you using?

Windows

What browser are you using?

Chrome

Describe the Bug

I followed the docs for github pages https://docs.astro.build/en/guides/deploy/github/#configure-astro-for-github-pages and for github pages I have set the serve directory to docs as welll ensure the build assets came from the docs folder github is able to find index html but index.html cant retrieve anything else.

Here is the link to the github repo of the issue https://github.com/windmillcode0/starlight_astro_gh_pages_doesnt_work

This cant been in a stackblitz because this is a deploy issue

Link to Minimal Reproducible Example

https://stackblitz.com/edit/withastro-astro-gdjr4r?file=astro.config.mjs

Participation

delucis commented 3 months ago

Thanks for the issue @windmillcode0!

Can I ask how and when you are building the contents of the docs/ directory? It looks like it was built without site and base set, so might need rebuilding?

I just tried deploying with the recommended GitHub Actions approach shown in the Astro Docs and it worked as expected (repo, deployment).

delucis commented 3 months ago

Based on this Discord post sounds like this is resolved 🙌