search

withered-magic / starpls

An LSP implementation for Starlark, the configuration language used by Bazel and Buck2.
Apache License 2.0
104 stars 9 forks source link

Bazel 7.3 archive_override should have strip_prefix #296

Open sluongng opened 5 days ago

sluongng commented 5 days ago

Right now, if I were to open BuildBuddy at this commit, I will get the following diagnostic

https://github.com/buildbuddy-io/buildbuddy/blob/b593de202b22ada3000dcf0e3b763124ff8c9007/MODULE.bazel#L48-L54

    4 # abseil-cpp 20240722.0 in BCR does not have feature parity with its github analog
    3 archive_override(
    2     module_name = "abseil-cpp",
    1     integrity = "sha256-9Q5awxGoE4Laf6dblzEOS5AGR0+VYKxG9UqZZ/B9SuM=",
E 52      strip_prefix = "abseil-cpp-20240722.0",     ■ Unexpected keyword argument "strip_prefix"
    1     urls = ["https://github.com/abseil/abseil-cpp/releases/download/20240722.0/abseil-cpp-20240722.0.tar.gz"],
    2 )

Bazel version is 7.3.0 Starpls version is v0.1.15 (pulled and built from HEAD)

Not sure if this is an issue with Bazel-generated proto, but I'm reporting it here first.

withered-magic commented 4 days ago

Thank you for the report! This is probably because the currently checked-in proto is a bit outdated, I'll put out a PR to update it