witheve / Eve

Better tools for thought
http://witheve.com
Apache License 2.0
7.16k stars 257 forks source link

Support all DOM events #795

Closed shamrin closed 7 years ago

shamrin commented 7 years ago

PR is not finished because I'm not sure about [#dom/event, event: "click"] part and about the explicit subscription. Comments?

untitled

cmontella commented 7 years ago

We have to sort of come up with a convention here. In the eve syntax, we have

search @event
  [#click]

Which would make sense to become [#dom/event/click]

I think we should resist the temptation to be too highly specific with tags though, keeping them shallow and getting more specific with attributes. "dom/event" is probably specific enough a tag, so I agree with the change you've made.

shamrin commented 7 years ago

Sorry for late reply! I'm closing this, because the issue was fixed by PR #823 and other changes.