search

witheve / Eve

Better tools for thought
http://witheve.com
Apache License 2.0
7.16k stars 257 forks source link

Let users watch for mouse-move events #854

Closed cassiebeckley closed 7 years ago

joshuafcole commented 7 years ago

Hey @ThatOtherPerson, we'd like to work with you to get this in, but since Eve 0.3 isn't really fast enough to receive a continuous slew of mouse move events, we'll need to do a more limited version. To start with, we'd like to bar this feature behind an #html/listener/mouse-position tag (just like hover is 1). The handler will bubble from the target and will only dispatch to Eve if at least one of the elements in the hierarchy has that listener. Additionally, it will only attach event information about the element(s) with that listener to keep volume down.

Once we've done that we'll do some qualitative testing to see if we also need to throttle the events.

Are you interested in spearheading this?

cassiebeckley commented 7 years ago

Yes, sounds good!

cassiebeckley commented 7 years ago

@joshuafcole I've tried implementing your suggestions, let me know if there's anything more I should fix.

cassiebeckley commented 7 years ago

@joshuafcole Thanks for the feedback! The PR has been updated.

joshuafcole commented 7 years ago

Sorry for the slow response, between writing an eve-mode for emacs, putting out some fires in 0.2, and preparing for the holidays my time has been fairly well accounted for. I should be much more available after the 4th!

cassiebeckley commented 7 years ago

No problem!

joshuafcole commented 7 years ago

Hey @ThatOtherPerson,

Since we're approaching end of life for 0.3, I'm going to close this PR. If you happen to free up after 0.4 is released, ping me and I'd be happy to help you port your work!