Add search - Githubissues

alexispurslane commented 7 years ago

Added the search function using codemirror's add-ons, as per issue #799.

joshuafcole commented 7 years ago

[x] Let's add an opaque white background to the searchbox. If you scroll down and invoke it while it's above text, it's quite hard to read.
[x] Let's also add the matches on scrollbar plugin to make the fact that we're still in search mode a little more obvious.

Other than that, looks good!

alexispurslane commented 7 years ago

Okay, I'm on it. I was already considering adding the matches on scroll bar plugin but wasn't sure about going beyond the problem directly stated by the issue. (: On Mon, Aug 28, 2017 at 6:04 PM Joshua Cole notifications@github.com wrote:

Let's add an opaque white background to the searchbox. If you scroll down and invoke it while it's above text, it's quite hard to read.

Let's also add the matches on scrollbar plugin https://codemirror.net/addon/search/matchesonscrollbar.js to make the fact that we're still in search mode a little more obvious.

Other than that, looks good!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/witheve/Eve/pull/878#issuecomment-325524450, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1Ml-nytIoneqQyj2WJHwE7wYtvW1abks5sc2OPgaJpZM4PE4hR .

-- Regards, Christopher

alexispurslane commented 7 years ago

Okay, I've made both of these changes, but for some inexplicable reason, package.json is reformatted and examples/quickstart.eve is... changed? How should I reset those files?

witheve / Eve

Add search #878