[php] subcommands are not loaded - Githubissues

withfig / autocomplete

IDE-style autocomplete for your existing terminal & shell

https://fig.io

MIT License

24.38k stars 5.4k forks source link

[php] subcommands are not loaded #2274

Open timboozle opened 4 months ago

timboozle commented 4 months ago

Sanity checks

[X] My issue relates to a specific CLI completion spec (e.g. git checkout is missing options in git completion spec). If your issue is more general, please create your issue here: withfig/fig
[X] I have searched github.com/withfig/autocomplete/issues and there are no duplicates of my issue
[X] I would like to work on this.

What CLI tool does this relate to?

php

Which statement makes the most sense?

There is a bug with this completion spec

Issue Details

https://github.com/withfig/autocomplete/blob/226e875eb562f88e7d63395f73c93559cc0e4a47/src/php.ts#L19 This Promise.all() does not seem to run at all so the subcommands are never loaded. It can be fixed by just awaiting the fileExists one by one but I don't know if that's desirable.