brew upgrade completely reinstalls fig

jonatan-ivanov commented 2 years ago

Sanity checks

[X] I have searched github.com/withfig/fig/issues and there are no duplicates of my issue
[X] I have run fig doctor in the affected terminal session
[X] I have typed 'git ' and included a screenshot of the Debugger (click the Fig icon in the macOS menu bar)

Issue Details

Description:

After upgrading fig with homebrew brew upgrade --greedy, it behaves like it would be a completely new installation (I assume it is and the brew formulae wipes everything off and reinstalls fig). So users need to:

Sign in and activate fig
Enable accessibility settings in System Preferences
Go through setup

every single time they update fig.

Environment

The issue is not with fig itself but with its brew installer though here are a few relevant snippets:

 ❯ brew --version
Homebrew 3.4.7
Homebrew/homebrew-core (git revision 5d40e5c04c1; last commit 2022-04-23)
Homebrew/homebrew-cask (git revision 296885167a; last commit 2022-04-23)

 ❯ fig diagnostic
# Fig Diagnostics
## Fig details:
  - Fig version: Version 1.0.57 (B439) [U.S.]
  - Bundle path: /Applications/Fig.app
  - Autocomplete: true
  - Settings.json: true
  - Accessibility: true
  - Number of specs: 0
  - Symlinked dotfiles: true
  - Only insert on tab: false
  - Keybindings path:
  - Installation Script: true
  - PseudoTerminal Path: [...]
  - SecureKeyboardInput: false
  - SecureKeyboardProcess: <none>
## Hardware Info:
  - Model Name: MacBook Pro
  - Model Identifier: MacBookPro16,1
## OS Info:
  - macOS 12.3.1 (21E258)

mschrage commented 2 years ago

Hey @jonatan-ivanov! Thanks for reporting this.

I think we will need to modify our uninstall script so that it takes an additional flag (fig app uninstall --zap) which will perform a more comprehensive deletion procedure.

Then we can have slightly different behaviors for a normal uninstall vs a zap. We'll need to modify the cask as well.

clo4 commented 2 years ago

Same thing happens when running brew upgrade fig

withfig / fig