withfig / fig

Public issue tracker for Fig.
https://fig.io
MIT License
2.05k stars 63 forks source link

bug: IntelliJ Terminal: unable to dismiss Fig suggestion pop-up with Esc Button #2688

Open luktomaszewski opened 1 year ago

luktomaszewski commented 1 year ago

Checks

Operating system

MacOS

Expected behaviour

I have a built-in terminal in IntelliJ (zsh + oh-my-zsh), and whenever I type a command, Fig begins to suggest a continuation of that command. However, if the suggestion is incorrect, I attempt to dismiss and close Fig's suggestion pop-up. Pressing Esc button doesn't close this pop-up, even though this is how I can reject Fig's suggestion in iTerm2 and the terminal in VSCode

Actual behaviour

At the moment, I can't dismiss the suggestion.

Steps to reproduce

  1. Launch IntelliJ.
  2. Open the terminal window.
  3. Begin typing a command.
  4. Attempt to dismiss the Fig suggestion pop-up by pressing the Esc button.

Environment

fig-details:
  - 2.16.0
hardware-info:
  - model: 
  - model-id: 
  - chip-id: Apple M1 Pro
  - cores: 8
  - mem: 16.00 GB
os-info:
  - macOS 13.4.1 (22F770820d)
environment:
  - shell: /bin/zsh
  - terminal: intellij-idea-ultimate
  - cwd: /Users/yo304e/IdeaProjects/ngfp/ngfp-shared-infrastructure
  - exe-path: /opt/homebrew/bin/fig
  - install-method: brew
  - env-vars:
    - FIGTERM_SESSION_ID: 0201fde7-93b2-47bb-bd14-735aad7c5f8b
    - FIG_JETBRAINS_SHELL_INTEGRATION: 1
    - FIG_SET_PARENT_CHECK: 1
    - FIG_TERM: 2.16.0
    - PATH: /Users/yo304e/.local/share/fig/plugins/git-open:/Users/yo304e/.sdkman/candidates/java/current/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/yo304e/.fig/bin:/Users/yo304e/.local/bin
    - SHELL: /bin/zsh
    - TERM: xterm-256color
    - __CFBundleIdentifier: com.jetbrains.intellij
    - FIG_PID: 45410
    - FIG_SET_PARENT: 0201fde7-93b2-47bb-bd14-735aad7c5f8b
uwaisdev commented 8 months ago

Checks

* [x]  I have searched [github.com/withfig/fig/issues](https://github.com/withfig/fig/issues?q=) and there are no duplicates of my issue

* [x]  I have run `fig doctor` in the affected terminal session

* [x]  I have run `fig restart` and replicated the issue again

Operating system

MacOS

Expected behaviour

I have a built-in terminal in IntelliJ (zsh + oh-my-zsh), and whenever I type a command, Fig begins to suggest a continuation of that command. However, if the suggestion is incorrect, I attempt to dismiss and close Fig's suggestion pop-up. Pressing Esc button doesn't close this pop-up, even though this is how I can reject Fig's suggestion in iTerm2 and the terminal in VSCode

Actual behaviour

At the moment, I can't dismiss the suggestion.

Steps to reproduce

1. Launch IntelliJ.

2. Open the terminal window.

3. Begin typing a command.

4. Attempt to dismiss the Fig suggestion pop-up by pressing the `Esc` button.

Environment

fig-details:
  - 2.16.0
hardware-info:
  - model: 
  - model-id: 
  - chip-id: Apple M1 Pro
  - cores: 8
  - mem: 16.00 GB
os-info:
  - macOS 13.4.1 (22F770820d)
environment:
  - shell: /bin/zsh
  - terminal: intellij-idea-ultimate
  - cwd: /Users/yo304e/IdeaProjects/ngfp/ngfp-shared-infrastructure
  - exe-path: /opt/homebrew/bin/fig
  - install-method: brew
  - env-vars:
    - FIGTERM_SESSION_ID: 0201fde7-93b2-47bb-bd14-735aad7c5f8b
    - FIG_JETBRAINS_SHELL_INTEGRATION: 1
    - FIG_SET_PARENT_CHECK: 1
    - FIG_TERM: 2.16.0
    - PATH: /Users/yo304e/.local/share/fig/plugins/git-open:/Users/yo304e/.sdkman/candidates/java/current/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/yo304e/.fig/bin:/Users/yo304e/.local/bin
    - SHELL: /bin/zsh
    - TERM: xterm-256color
    - __CFBundleIdentifier: com.jetbrains.intellij
    - FIG_PID: 45410
    - FIG_SET_PARENT: 0201fde7-93b2-47bb-bd14-735aad7c5f8b

+1 on this issue.