search

withfig / fig

Public issue tracker for Fig.
https://fig.io
MIT License
2.04k stars 54 forks source link

fish issue when running fig doctor #2777

Open funkadelic opened 8 months ago

funkadelic commented 8 months ago

Checks

Operating system

macOS 14.0.0 (23A344)

Expected behaviour

no issues when I run fig doctor

Actual behaviour

I get an error when checking fish

✘ Fish is up to date: failed parsing fish version

   0: failed parsing fish version
   1: empty string, expected a semver version

Location:
   fig_cli/src/cli/doctor.rs:2189

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 3 frames hidden ⋮
   4: <fig_cli::cli::doctor::FishVersionCheck as fig_cli::cli::doctor::DoctorCheck>::check::{{closure}}::h6672f753a9cc30a2
      at <unknown source file>:<unknown line>
   5: fig_cli::cli::doctor::run_checks::{{closure}}::h41f8737bc2d578a1
      at <unknown source file>:<unknown line>
   6: fig_cli::cli::doctor::doctor_cli::{{closure}}::{{closure}}::hbd90eb319ce59f1e
      at <unknown source file>:<unknown line>
   7: fig_cli::cli::Cli::execute::{{closure}}::h7fe279a0b07f0a96
      at <unknown source file>:<unknown line>
   8: <tokio::future::maybe_done::MaybeDone<Fut> as core::future::future::Future>::poll::hdd3b1b05318c766e
      at <unknown source file>:<unknown line>
   9: <tokio::future::poll_fn::PollFn<F> as core::future::future::Future>::poll::hd78492bdf70b9ae4
      at <unknown source file>:<unknown line>
  10: tokio::runtime::park::CachedParkThread::block_on::he72310075f57ba6b
      at <unknown source file>:<unknown line>
  11: tokio::runtime::runtime::Runtime::block_on::h52f4ffbaa49d22ee
      at <unknown source file>:<unknown line>
  12: fig_cli::main::had0da541d460ea2c
      at <unknown source file>:<unknown line>
  13: std::sys_common::backtrace::__rust_begin_short_backtrace::h110deee9667c35eb
      at <unknown source file>:<unknown line>
  14: std::rt::lang_start::{{closure}}::he0c40551bea8dc7c
      at <unknown source file>:<unknown line>
  15: std::rt::lang_start_internal::heb9ef1177a8102d0
      at <unknown source file>:<unknown line>
  16: _main<unknown>
      at <unknown source file>:<unknown line>

Steps to reproduce

i simply run fig doctor

Environment

fig-details:
  - 2.17.0
hardware-info:
  - model: 
  - model-id: 
  - chip-id: Apple M1
  - cores: 8
  - mem: 8.00 GB
os-info:
  - macOS 14.0.0 (23A344)
environment:
  - shell: /bin/zsh
  - terminal: iterm
  - cwd: /Users/norm
  - exe-path: /opt/homebrew/bin/fig
  - install-method: unknown
  - env-vars:
    - FIGTERM_SESSION_ID: 62f9e956-4251-4d59-a8b6-72e458905cb3
    - FIG_SET_PARENT_CHECK: 1
    - FIG_TERM: 2.17.0
    - PATH: /Users/norm/.nvm/versions/node/v18.18.0/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/Applications/iTerm.app/Contents/Resources/utilities:/Users/norm/.fig/bin:/Users/norm/.local/bin
    - SHELL: /bin/zsh
    - TERM: xterm-256color
    - __CFBundleIdentifier: com.googlecode.iterm2
    - FIG_PID: 11116
    - FIG_SET_PARENT: 62f9e956-4251-4d59-a8b6-72e458905cb3
simonbcn commented 8 months ago

Same problem:

RUST_BACKTRACE=1 fig doctor
Let's check if you're logged in...
✔ Logged into Fig

Let's check your dotfiles...
● /Users/juan/.bashrc does not source pre integration
● /Users/juan/.profile does not source pre integration
● /Users/juan/.zshrc does not source pre integration
● /Users/juan/.zprofile does not source pre integration
✘ fish ~/.config/fish/conf.d/00_fig_pre.fish integration check: /Users/juan/.config/fish/conf.d/00_fig_pre.fish does not exist.

   0: /Users/juan/.config/fish/conf.d/00_fig_pre.fish does not exist.

Location:
   fig_cli/src/cli/doctor.rs:1169

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: backtrace::capture::Backtrace::new::h6496118ba9105351
      at <unknown source file>:<unknown line>
   2: color_eyre::config::EyreHook::into_eyre_hook::{{closure}}::hfd236e240bfb1ba0
      at <unknown source file>:<unknown line>
   3: eyre::error::<impl eyre::Report>::from_std::h598f3fb9c024f6f6
      at <unknown source file>:<unknown line>
   4: <fig_cli::cli::doctor::DotfileCheck as fig_cli::cli::doctor::DoctorCheck<core::option::Option<fig_util::shell::Shell>>>::check::{{closure}}::h68579661772e58ea
      at <unknown source file>:<unknown line>
   5: fig_cli::cli::doctor::doctor_cli::{{closure}}::{{closure}}::hbd90eb319ce59f1e
      at <unknown source file>:<unknown line>
   6: fig_cli::cli::Cli::execute::{{closure}}::h7fe279a0b07f0a96
      at <unknown source file>:<unknown line>
   7: <tokio::future::maybe_done::MaybeDone<Fut> as core::future::future::Future>::poll::hdd3b1b05318c766e
      at <unknown source file>:<unknown line>
   8: <tokio::future::poll_fn::PollFn<F> as core::future::future::Future>::poll::hd78492bdf70b9ae4
      at <unknown source file>:<unknown line>
   9: tokio::runtime::park::CachedParkThread::block_on::he72310075f57ba6b
      at <unknown source file>:<unknown line>
  10: tokio::runtime::runtime::Runtime::block_on::h52f4ffbaa49d22ee
      at <unknown source file>:<unknown line>
  11: fig_cli::main::had0da541d460ea2c
      at <unknown source file>:<unknown line>
  12: std::sys_common::backtrace::__rust_begin_short_backtrace::h110deee9667c35eb
      at <unknown source file>:<unknown line>
  13: std::rt::lang_start::{{closure}}::he0c40551bea8dc7c
      at <unknown source file>:<unknown line>
  14: std::rt::lang_start_internal::heb9ef1177a8102d0
      at <unknown source file>:<unknown line>
  15: _main<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
✘ fish ~/.config/fish/conf.d/99_fig_post.fish integration check: /Users/juan/.config/fish/conf.d/99_fig_post.fish does not exist.

   0: /Users/juan/.config/fish/conf.d/99_fig_post.fish does not exist.

Location:
   fig_cli/src/cli/doctor.rs:1169

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: backtrace::capture::Backtrace::new::h6496118ba9105351
      at <unknown source file>:<unknown line>
   2: color_eyre::config::EyreHook::into_eyre_hook::{{closure}}::hfd236e240bfb1ba0
      at <unknown source file>:<unknown line>
   3: eyre::error::<impl eyre::Report>::from_std::h598f3fb9c024f6f6
      at <unknown source file>:<unknown line>
   4: <fig_cli::cli::doctor::DotfileCheck as fig_cli::cli::doctor::DoctorCheck<core::option::Option<fig_util::shell::Shell>>>::check::{{closure}}::h68579661772e58ea
      at <unknown source file>:<unknown line>
   5: fig_cli::cli::doctor::doctor_cli::{{closure}}::{{closure}}::hbd90eb319ce59f1e
      at <unknown source file>:<unknown line>
   6: fig_cli::cli::Cli::execute::{{closure}}::h7fe279a0b07f0a96
      at <unknown source file>:<unknown line>
   7: <tokio::future::maybe_done::MaybeDone<Fut> as core::future::future::Future>::poll::hdd3b1b05318c766e
      at <unknown source file>:<unknown line>
   8: <tokio::future::poll_fn::PollFn<F> as core::future::future::Future>::poll::hd78492bdf70b9ae4
      at <unknown source file>:<unknown line>
   9: tokio::runtime::park::CachedParkThread::block_on::he72310075f57ba6b
      at <unknown source file>:<unknown line>
  10: tokio::runtime::runtime::Runtime::block_on::h52f4ffbaa49d22ee
      at <unknown source file>:<unknown line>
  11: fig_cli::main::had0da541d460ea2c
      at <unknown source file>:<unknown line>
  12: std::sys_common::backtrace::__rust_begin_short_backtrace::h110deee9667c35eb
      at <unknown source file>:<unknown line>
  13: std::rt::lang_start::{{closure}}::he0c40551bea8dc7c
      at <unknown source file>:<unknown line>
  14: std::rt::lang_start_internal::heb9ef1177a8102d0
      at <unknown source file>:<unknown line>
  15: _main<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.

Let's make sure Fig is setup correctly...
✔ Fig bin exists
✘ PATH contains ~/.local/bin: Path does not contain ~/.local/bin
✘ PATH contains ~/.fig/bin: Path does not contain ~/.fig/bin
✔ Settings Corruption
✔ State Corruption
✘ Fig Integration: Figterm is not running in this terminal, please try restarting your terminal

  FIG_TERM=
✘ SSH integration: /Users/juan/.fig/ssh does not exist.

   0: /Users/juan/.fig/ssh does not exist.

Location:
   fig_cli/src/cli/doctor.rs:1253

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: backtrace::capture::Backtrace::new::h6496118ba9105351
      at <unknown source file>:<unknown line>
   2: color_eyre::config::EyreHook::into_eyre_hook::{{closure}}::hfd236e240bfb1ba0
      at <unknown source file>:<unknown line>
   3: eyre::error::<impl eyre::Report>::from_std::h598f3fb9c024f6f6
      at <unknown source file>:<unknown line>
   4: <fig_cli::cli::doctor::SshIntegrationCheck as fig_cli::cli::doctor::DoctorCheck>::check::{{closure}}::hc907586d68f3667c
      at <unknown source file>:<unknown line>
   5: fig_cli::cli::doctor::run_checks::{{closure}}::h41f8737bc2d578a1
      at <unknown source file>:<unknown line>
   6: fig_cli::cli::doctor::doctor_cli::{{closure}}::{{closure}}::hbd90eb319ce59f1e
      at <unknown source file>:<unknown line>
   7: fig_cli::cli::Cli::execute::{{closure}}::h7fe279a0b07f0a96
      at <unknown source file>:<unknown line>
   8: <tokio::future::maybe_done::MaybeDone<Fut> as core::future::future::Future>::poll::hdd3b1b05318c766e
      at <unknown source file>:<unknown line>
   9: <tokio::future::poll_fn::PollFn<F> as core::future::future::Future>::poll::hd78492bdf70b9ae4
      at <unknown source file>:<unknown line>
  10: tokio::runtime::park::CachedParkThread::block_on::he72310075f57ba6b
      at <unknown source file>:<unknown line>
  11: tokio::runtime::runtime::Runtime::block_on::h52f4ffbaa49d22ee
      at <unknown source file>:<unknown line>
  12: fig_cli::main::had0da541d460ea2c
      at <unknown source file>:<unknown line>
  13: std::sys_common::backtrace::__rust_begin_short_backtrace::h110deee9667c35eb
      at <unknown source file>:<unknown line>
  14: std::rt::lang_start::{{closure}}::he0c40551bea8dc7c
      at <unknown source file>:<unknown line>
  15: std::rt::lang_start_internal::heb9ef1177a8102d0
      at <unknown source file>:<unknown line>
  16: _main<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.

Let's make sure Fig is running...
✔ Fig is running
✔ Fig socket exists
✔ Daemon
✔ Daemon diagnostics

Let's see if Fig is in a working state...
✘ Figterm: No FIGTERM_SESSION_ID

   0: No FIGTERM_SESSION_ID
   1: environment variable not found

Location:
   fig_cli/src/cli/doctor.rs:658

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: backtrace::capture::Backtrace::new::h6496118ba9105351
      at <unknown source file>:<unknown line>
   2: color_eyre::config::EyreHook::into_eyre_hook::{{closure}}::hfd236e240bfb1ba0
      at <unknown source file>:<unknown line>
   3: eyre::error::<impl eyre::Report>::from_msg::h19677698efd36be8
      at <unknown source file>:<unknown line>
   4: <fig_cli::cli::doctor::FigtermSocketCheck as fig_cli::cli::doctor::DoctorCheck>::check::{{closure}}::hccebf93759665880
      at <unknown source file>:<unknown line>
   5: fig_cli::cli::doctor::run_checks::{{closure}}::h41f8737bc2d578a1
      at <unknown source file>:<unknown line>
   6: fig_cli::cli::doctor::doctor_cli::{{closure}}::{{closure}}::hbd90eb319ce59f1e
      at <unknown source file>:<unknown line>
   7: fig_cli::cli::Cli::execute::{{closure}}::h7fe279a0b07f0a96
      at <unknown source file>:<unknown line>
   8: <tokio::future::maybe_done::MaybeDone<Fut> as core::future::future::Future>::poll::hdd3b1b05318c766e
      at <unknown source file>:<unknown line>
   9: <tokio::future::poll_fn::PollFn<F> as core::future::future::Future>::poll::hd78492bdf70b9ae4
      at <unknown source file>:<unknown line>
  10: tokio::runtime::park::CachedParkThread::block_on::he72310075f57ba6b
      at <unknown source file>:<unknown line>
  11: tokio::runtime::runtime::Runtime::block_on::h52f4ffbaa49d22ee
      at <unknown source file>:<unknown line>
  12: fig_cli::main::had0da541d460ea2c
      at <unknown source file>:<unknown line>
  13: std::sys_common::backtrace::__rust_begin_short_backtrace::h110deee9667c35eb
      at <unknown source file>:<unknown line>
  14: std::rt::lang_start::{{closure}}::he0c40551bea8dc7c
      at <unknown source file>:<unknown line>
  15: std::rt::lang_start_internal::heb9ef1177a8102d0
      at <unknown source file>:<unknown line>
  16: _main<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
✔ Insertion lock does not exist
✔ Autocomplete dev mode
✔ Plugin dev mode
✔ Dashboard is loading from the correct URL
✔ Autocomplete is loading from the correct URL

Let's check if your system is compatible...
✔ OS is supported
✔ Fish is up to date
✔ Jetbrains Toolbox Check

Let's check fig diagnostic...
✔ Compatible shell
✔ Fig app installed in the right place
✔ Autocomplete is enabled
✔ Fig CLI path
✔ Accessibility enabled

Let's check your terminal integrations...
✔ Terminal support

It would be nice to have an option in the fig command that would show the system configuration/environment important when reporting an issue.

grant0417 commented 8 months ago

Can one of you run fish -v?

funkadelic commented 8 months ago

Can one of you run fish -v?

@grant0417 yep

$ fish -v
fish, version 1.23.1
grant0417 commented 8 months ago

Well you need a version of fish >=3.3.0 for Fig to work. Are you running a very old version?

funkadelic commented 8 months ago

ah. i am not sure where/when i installed fish but checked that I didn't install via brew, so I brew install fish (which installed 3.6.1) , restarted my shell, and fig doctor is no longer complaining. thanks!

simonbcn commented 8 months ago

I was able to fix it. I restarted the computer (for another issue) and when I logged in, the main fig window opened and alerted me that the shell installation had not been done correctly and showed me a button to fix it, I clicked it and it was fixed.