Autocomplete-engine has memory leak

[CobreDev]

Description:

Please include a detailed description of the issue (and an image or screen recording, if applicable) https://app.withfig.ocm seems to be hogging memory. This has happened several times in the last few days, after reboots and such. Nothing I can see triggers it.

https://twitter.com/cobredev/status/1459701333884289024

Details:

macOS	Fig	Shell
12.0.1	Version 1.0.52 (B310)	/bin/zsh

fig diagnostic

Version 1.0.52 (B310) [U.S.] 
UserShell: /bin/zsh
Bundle path: /Applications/Fig.app
Autocomplete: true
Settings.json: true
CLI installed: true
CLI tool path: /Users/cobre/.fig/bin/fig
Accessibility: true
Number of specs: 1
SSH Integration: false
Tmux Integration: false
Keybindings path: 
iTerm Integration: true 
Hyper Integration: false
VSCode Integration: true
Docker Integration: false
Symlinked dotfiles: false
Only insert on tab: false
Installation Script: true
PseudoTerminal Path: /Users/cobre/Azule:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin:/Users/cobre/.fig/bin
SecureKeyboardInput: false
SecureKeyboardProcess: 
Current active process: ??? (???) - ???
Current working directory: ???
Current window identifier: ???

[CobreDev]

Should've added: I've looked through Console a little bit (Mostly at Log Reports and Diagnostic Reports), and found nothing. I'll try to see what I can see next time it happens

[mschrage]

That would be really helpful @CobreDev!

A few other diagnostics you can run:

1. How long does it take for the memory to increase to this level? Does it happen right away?
2. Can you run cat ~/.fig/history | wc -l and share the output here?

[CobreDev]

Finally at my computer, though I'm not having the issue this second.

1. I'm not sure, I don't pay close enough attention to it and being on an M1 Mac, it takes a bit to notice any performance decreases.
2. When I run that, I get 2562 as the output

[fedeci]

Well, that's strange, may it be some optimization problem on M1?

[CobreDev]

How long does it take for the memory to increase to this level? Does it happen right away?

@mschrage Just had more time to mess around with it, it looks like this happens just after I relaunch Fig and use the autocomplete window in iTerm

[fedeci]

@CobreDev can you post your .zshrc? Are you using ENABLE_CORRECTION="true" in it?

[CobreDev]

export VISUAL="$EDITOR"

eval "$(starship init zsh)"

#### FIG ENV VARIABLES ####
# Please make sure this block is at the start of this file.
[ -s ~/.fig/shell/pre.sh ] && source ~/.fig/shell/pre.sh
#### END FIG ENV VARIABLES ####
# If you come from bash you might have to change your $PATH.
# export PATH=$HOME/bin:/usr/local/bin:$PATH

# Path to your oh-my-zsh installation.
export ZSH="/Users/cobre/.oh-my-zsh"

# Set name of the theme to load --- if set to "random", it will
# load a random theme each time oh-my-zsh is loaded, in which case,
# to know which specific one was loaded, run: echo $RANDOM_THEME
# See https://github.com/ohmyzsh/ohmyzsh/wiki/Themes
ZSH_THEME="awesomepanda"

# Set list of themes to pick from when loading at random
# Setting this variable when ZSH_THEME=random will cause zsh to load
# a theme from this variable instead of looking in $ZSH/themes/
# If set to an empty array, this variable will have no effect.
# ZSH_THEME_RANDOM_CANDIDATES=( "robbyrussell" "agnoster" )

# Uncomment the following line to use case-sensitive completion.
# CASE_SENSITIVE="true"

# Uncomment the following line to use hyphen-insensitive completion.
# Case-sensitive completion must be off. _ and - will be interchangeable.
# HYPHEN_INSENSITIVE="true"

# Uncomment one of the following lines to change the auto-update behavior
# zstyle ':omz:update' mode disabled  # disable automatic updates
# zstyle ':omz:update' mode auto      # update automatically without asking
# zstyle ':omz:update' mode reminder  # just remind me to update when it's time

# Uncomment the following line to change how often to auto-update (in days).
# zstyle ':omz:update' frequency 13

# Uncomment the following line if pasting URLs and other text is messed up.
# DISABLE_MAGIC_FUNCTIONS="true"

# Uncomment the following line to disable colors in ls.
# DISABLE_LS_COLORS="true"

# Uncomment the following line to disable auto-setting terminal title.
# DISABLE_AUTO_TITLE="true"

# Uncomment the following line to enable command auto-correction.
ENABLE_CORRECTION="true"

# Uncomment the following line to display red dots whilst waiting for completion.
# You can also set it to another string to have that shown instead of the default red dots.
# e.g. COMPLETION_WAITING_DOTS="%F{yellow}waiting...%f"
# Caution: this setting can cause issues with multiline prompts in zsh < 5.7.1 (see #5765)
# COMPLETION_WAITING_DOTS="true"

# Uncomment the following line if you want to disable marking untracked files
# under VCS as dirty. This makes repository status check for large repositories
# much, much faster.
# DISABLE_UNTRACKED_FILES_DIRTY="true"

# Uncomment the following line if you want to change the command execution time
# stamp shown in the history command output.
# You can set one of the optional three formats:
# "mm/dd/yyyy"|"dd.mm.yyyy"|"yyyy-mm-dd"
# or set a custom format using the strftime function format specifications,
# see 'man strftime' for details.
# HIST_STAMPS="mm/dd/yyyy"

# Would you like to use another custom folder than $ZSH/custom?
# ZSH_CUSTOM=/path/to/new-custom-folder

# Which plugins would you like to load?
# Standard plugins can be found in $ZSH/plugins/
# Custom plugins may be added to $ZSH_CUSTOM/plugins/
# Example format: plugins=(rails git textmate ruby lighthouse)
# Add wisely, as too many plugins slow down shell startup.
plugins=(
    git
    themes
    xcode
    )
source $ZSH/oh-my-zsh.sh

# User configuration

# export MANPATH="/usr/local/man:$MANPATH"

# You may need to manually set your language environment
# export LANG=en_US.UTF-8

# Preferred editor for local and remote sessions
# if [[ -n $SSH_CONNECTION ]]; then
#   export EDITOR='vim'
# else
#   export EDITOR='mvim'
# fi

# Compilation flags
# export ARCHFLAGS="-arch x86_64"

# Set personal aliases, overriding those provided by oh-my-zsh libs,
# plugins, and themes. Aliases can be placed here, though oh-my-zsh
# users are encouraged to define aliases within the ZSH_CUSTOM folder.
# For a full list of active aliases, run `alias`.
#
# Example aliases
# alias zshconfig="mate ~/.zshrc"
# alias ohmyzsh="mate ~/.oh-my-zsh"

#### FIG ENV VARIABLES ####
# Please make sure this block is at the end of this file.
[ -s ~/.fig/fig.sh ] && source ~/.fig/fig.sh
#### END FIG ENV VARIABLES ####

# Add RVM to PATH for scripting. Make sure this is the last PATH variable change.
export PATH="$PATH:$HOME/.rvm/bin"

[fedeci]

I can confirm ENABLE_CORRECTION="true" is the cause of the memory leak, I was able to successfully reproduce it!

[CobreDev]

Ah interesting, i’ll play around with it!

On Feb 9, 2022, at 06:55, Federico Ciardi @.***> wrote:

 I can confirm ENABLE_CORRECTION="true" is the cause of the memory leak, I was able to successfully reproduce it!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[fedeci]

This will be fixed in the next autocomplete-engine version!