withfig / fig

Public issue tracker for Fig.
https://fig.io
MIT License
2.05k stars 63 forks source link

Fig fails if not installed to /Applications/Fig.app #679

Open dombarnes opened 2 years ago

dombarnes commented 2 years ago

Sanity checks

Issue Details

Description:

Running fig app install fails if the macOS application is location in ~/Applications instead of the system level /Applications folder. Output:

fig app install
Tag is
cp: /Applications/Fig.app/Contents/MacOS//figterm: No such file or directory
cp: /Applications/Fig.app/Contents/MacOS//figterm: No such file or directory
cp: /Applications/Fig.app/Contents/MacOS//figterm: No such file or directory
/Users/<username>/.fig/tools/install_and_upgrade.sh: line 79: /Applications/Fig.app/Contents/MacOS//figcli: No such file or directory
success

Environment

Fig Version: Version 1.0.52 (B328) [British]
UserShell: /bin/zsh
Bundle path: /Users/domster83/Applications/Fig.app
Autocomplete: true
Settings.json: true
CLI installed: true
CLI tool path: /usr/local/bin/fig
Accessibility: true
Number of specs: 0
SSH Integration: false
Tmux Integration: false
Keybindings path: <none>
iTerm Integration: installed!
Hyper Integration: application is not present.
VSCode Integration: installed!
Docker Integration: false
Symlinked dotfiles: true
Only insert on tab: false
Installation Script: true
PseudoTerminal Path: /Users/domster83/.rbenv/shims:/Users/domster83/.google-cloud-sdk/bin:/Users/domster83/laptop/bin::/Users/domster83/.android/cmdline-tools/latest/bin:/Users/domster83/.android/cmdline-tools/tools/bin:/Users/domster83/.android/platform-tools:/Users/domster83/.android/emulator:~/.flutter/bin:/Applications/Visual Studio Code.app/Contents/Resources/app/bin:/usr/local/sbin:/usr/local/lib/node_modules:/usr/local/opt/node@14/bin:/usr/local/heroku/bin:/usr/local/opt/curl/bin:/Library/Developer/Toolchains/swift-latest.xctoolchain/usr/bin:/usr/local/opt/openssl@1.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/Public:/usr/local/MacGPG2/bin:/usr/local/share/dotnet:~/.dotnet/tools:/Library/Apple/usr/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/domster83/.fig/bin
SecureKeyboardInput: false
SecureKeyboardProcess: <none>
Current active process: ??? (???) - ???
Current working directory: /Users/domster83/workprojects/TTV4/CRM/rails
Current window identifier: 898/0C6B20AC-F86D-406F-BFEE-7C7CCACB8210% (com.googlecode.iterm2)
Path: /Users/domster83/.rbenv/shims:/Users/domster83/.google-cloud-sdk/bin:/Users/domster83/laptop/bin::/Users/domster83/.android/cmdline-tools/latest/bin:/Users/domster83/.android/cmdline-tools/tools/bin:/Users/domster83/.android/platform-tools:/Users/domster83/.android/emulator:~/.flutter/bin:/Applications/Visual Studio Code.app/Contents/Resources/app/bin:/usr/local/sbin:/usr/local/lib/node_modules:/Users/domster83/.yarn/bin:/usr/local/opt/node@14/bin:/usr/local/heroku/bin:/usr/local/opt/curl/bin:/Library/Developer/Toolchains/swift-latest.xctoolchain/usr/bin:/usr/local/opt/openssl@1.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/Public:/usr/local/MacGPG2/bin:/usr/local/share/dotnet:~/.dotnet/tools:/Library/Apple/usr/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/domster83/.fig/bin
Fig environment variables:
  - TERM_SESSION_ID=w0t0p0:0C6B20AC-F86D-406F-BFEE-7C7CCACB8210
  - FIG_INTEGRATION_VERSION=5
  - FIG_TERM=1
  - FIG_TERM_VERSION=3
  - FIG_ENV_VAR=1
  - FIG_CHECKED_PROMPTS=1
mschrage commented 2 years ago

Hey @dombarnes! Thanks for reporting this. Definitely an oversight on our end and I think it should be a small change.

Purely out of curiosity, why do you want Fig.app to be in ~/Applications rather than /Applications?

dombarnes commented 2 years ago

Purely a mental organisation thing for me. Mines a work computer so the stuff that is more general use (slack, Xcode, etc) go in /Applications and all the extra apps I use to make life easier go in my user folder.

On 7 Dec 2021, at 18:29, Matt Schrage @.***> wrote:

 Hey @dombarnes! Thanks for reporting this. Definitely an oversight on our end and I think it should be a small change.

Purely out of curiosity, why do you want Fig.app to be in ~/Applications rather than /Applications?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

clo4 commented 2 years ago

This is also useful on user accounts that don't have admin permissions, or for when you don't want it to be installed system-wide (eg. partner's laptop).

Generalising this to "create symlinks to wherever the app is running from" will also allow people to install to, say, /Applications/Development/Fig.app and use fig doctor if they move it.