search

withfig / fig

Public issue tracker for Fig.
https://fig.io
MIT License
2.04k stars 54 forks source link

Add xonsh shell support #69

Open anki-code opened 3 years ago

anki-code commented 3 years ago

Hi! Thank you for the interesting project! I'm going to create this by reference from Matt Schrage.

Please add the xonsh shell support.

Thanks!

For community

:arrow_down: Please click the :+1: reaction instead of leaving a +1 or :+1: comment

mschrage commented 3 years ago

Thanks for creating the issue!

mschrage commented 3 years ago

Hey @anki-code!

Briefly looked into this just now and it seems like seems like adding xonsh support is possible!

We would need to add Fig hooks to the on_precommand and on_post_prompt events. You can see the zsh implementation for reference.

All of the shell integrations are open source, so if you're interested in contributing this, let me know!

(PS. Do you still need an invite?)

anki-code commented 3 years ago

Briefly looked into this just now and it seems like seems like adding xonsh support is possible!

Yeah, with xonsh you can implement significant more incredible things with Fig.

We would need to add Fig hooks to the on_precommand and on_post_prompt events.

Also this could be implemented as a xontrib (xonsh contribution/extension) for Fig:

All of the shell integrations are open source, so if you're interested in contributing this, let me know! (PS. Do you still need an invite?)

It will be great if you make a first try and put here a few words about result. Then I can give an advice or continue the creation of proof of concept when I'll back to Fig.

PS: You can also add the Fig support to xxh project (Bring your favorite shell wherever you go through the ssh) like zoxide prerun plugin.

KadenWolff commented 1 year ago

Hey, I'm interested in working on this integration. Could someone direct me to some resources to start building this, and any advice for doing this? Thanks!

anki-code commented 1 year ago

Hello @KadenWolff! Ask me if you have any questions about xonsh. Me first step references in my comment above. If you mean Fig`s side I can't help but I believe the documentation or support could help. Good luck with this!