withoutboats / failure_derive

derive macro for the Fail trait
Apache License 2.0
24 stars 6 forks source link

Dependencies are out-of-date causing dependent packages to build them twice #12

Open briansmith opened 6 years ago

briansmith commented 6 years ago

Currently Cargo.toml has:

[dependencies]
quote = "0.3.15"
syn = "0.11.11"
synstructure = "0.6.0"

Other libraries my project depends on require:

It would be great if failure_derive could pick up those new versions so that dependent projects like mine don't have to download and compile multiple versions of these packages.

I attempted to do this by updating Cargo.toml like so:

 [dependencies]
-quote = "0.3.15"
-syn = "0.11.11"
-synstructure = "0.6.0"
+quote = "0.4.2"
+syn = "0.12.13"
+synstructure = "0.7.0"

However, this broke the build. Unfortunately I don't know enough about writing macros using syn and quote to fix this myself.

mexus commented 6 years ago

I'm into it. They've changed some stuff in syn in that 11->12 update, hopefully I'll be able to migrate the code without hitting any major problems.

If somebody works on that already please ping me so we don't do the same job twice (or thrice or ...).

withoutboats commented 6 years ago

There's an open PR already in rust-lang-nursery/failure#179

mexus commented 6 years ago

Oh boy. Thanks for mentioning!

briansmith commented 6 years ago

There's an open PR already in rust-lang-nursery/failure#179

What is the status of this repo (withoutboats/failure_derive) to that one (rust-lang-nursery/failure)? Is rust-lang-nursery/failure replacing this one?

withoutboats commented 6 years ago

Yea, this code was moved into the main repo. I'll shut this repo down once failure 1.0 is released.