search

withoutboats / notty

A new kind of terminal
GNU Affero General Public License v3.0
2.31k stars 41 forks source link

Make Command more opaque. #36

Closed withoutboats closed 8 years ago

withoutboats commented 8 years ago

In order to eventually make Terminal an opaque type, commands need to be passed to a terminal method, instead of calling methods on terminal publicly. Additionally, proper local echo support will require a certain consistent dispatch when commands are applied, unless they are applied internally. This refactor changes no behavior, but is a step toward reducing the public API of the notty library.

waynr commented 8 years ago

If you are just going to merge your own PRs, why even bother opening them?

ysangkok commented 8 years ago

It still groups commits and makes a discussion thread for each story. I always thought of that as the reason, but maybe withoutboats has more reasons.