search

withspectrum / slate-mentions

Add support for mentions to your Slate editor.
MIT License
22 stars 5 forks source link

Example build error #6

Open oyeanuj opened 7 years ago

oyeanuj commented 7 years ago

Hey @mxstbr, I was going to try and play around and add some stuff but can't run the example due to this error: 

Failed to compile.

Error in ../~/react-portal/build/portal.js
Module not found: Can't resolve 'react-dom' in '/Users/anuj/Github/slate-mentions/node_modules/react-portal/build'

If I do yarn run start --watch, then this error prevents development server from starting as well.

mxstbr commented 7 years ago

That's... awkward. Maybe slate-mentions needs to depend on react-dom?

For now you should be able to fix it by running npm i react-dom in the root directory I think

jameskraus commented 7 years ago

FYI, installing react-dom in the root directory didn't fix the issue for me.

mxstbr commented 7 years ago

Hmm, that's no good. I don't have time to work on this at the minute, will be back on this in a week or two.

jameskraus commented 7 years ago

Welp, I reread the README and got it working by building slate-mentions. Thanks for the reply. (And by working, I mean working after npm i react-dom)

mxstbr commented 7 years ago

That's great to hear, I'd appreciate a PR adding a dependency on react-dom!

jameskraus commented 7 years ago

@mxstbr #9