search

witjoh / puppet-single_user_rvm

Install and manage RVM and Ruby installations in Single-User mode.
1 stars 5 forks source link

Relax dependency for libreadline for Debian/Ubuntu #6

Open usev6 opened 3 years ago

usev6 commented 3 years ago

Fixes https://github.com/witjoh/puppet-single_user_rvm/issues/5

witjoh commented 2 years ago

Could you rebase and resolve the conflict ? Then I can merge your PR's. Thanks for them ... Ans sorry to be so late. Didn't pay lot of attention on this repo ...

usev6 commented 2 years ago

I'd guess that this PR isn't necessary anymore after 9f521910a2. The primary problem described in https://github.com/witjoh/puppet-single_user_rvm/issues/5 should be solved now, because the code no longer tries to install the package libreadline6. Unfortunately I can't easily test that at the moment.

I'm not sure if it's better to install libreadline6-dev (as done by @genebean) than libreadline-dev as was my suggestion. But from what I'm seeing both versions should get the job done.

So this PR could probably be closed.