61: Error-Key-Specific Error Messages in Client - [merged] #91

Closed raffaelfoidl closed 2 years ago

In GitLab by @11775820 on Feb 4, 2022, 18:19

Merges 61-error-key-specific-error-messages-in-client -> develop

Closes #61.

I don't know if it's the best way. But for testing, I simply threw some ServerException at the start of an endpoint method with a random ServerError argument and checked whether the correct localized error message pops up in the app when triggering the affected endpoint.

In GitLab by @11775820 on Feb 6, 2022, 11:50

Commented on client/lib/localization/app_en.arb line 843

I don't know if we want to address users directly. If not, I don't know how to word it while being succinct.

-> 50cee75951792a105bc2fa25b0f4ddaa8390e9b9

(typo fixed in a later commit)

In GitLab by @11775820 on Feb 6, 2022, 11:50

Commented on client/lib/localization/app_en.arb line 839

When working on the client, shouldn't we strive for error messages that are as useful (i.e. helpful, not confusing) as possible to the actual user?

Yes, of course.

However, as I noted in another comment, my primary goal for this ticket was to implement the infrastructure to be able to map error codes to messages in the first place. I did not care too much about the messages themselves, because - in the context of the PR - it is not too important (that's why I blatantly copied the Java docs). For a "good" product, we certainly should provide the most helpful error messages possible.

I tried to make some error messages better in the commit below. However, in my opinion, it's debatable if we should invest too many resources into making the error messages more descriptive, especially at the current point in time. From my point of view, it's good enough for the time being. But your call.

-> 31b9f714ad20a6e8a8c0d885d536fec8bc51efb1

In GitLab by @11712616 on Feb 6, 2022, 12:44

Commented on client/lib/localization/app_en.arb line 731

Regex king

In GitLab by @11712616 on Feb 6, 2022, 12:44

Commented on client/lib/localization/app_en.arb line 743

I think we only need one "when" ;)

In GitLab by @11712616 on Feb 6, 2022, 12:44

Commented on client/lib/localization/app_en.arb line 839

Nice, thanks!

In GitLab by @11712616 on Feb 6, 2022, 12:44

Commented on client/lib/widgets/common/erorr_key_translator.dart line 59