witnessmenow / ESP32-Cheap-Yellow-Display

Building a community around a cheap ESP32 Display with a touch screen
MIT License
1.27k stars 128 forks source link

fix: upgrade to esphome 2023.12 API #112

Closed arthurlutz closed 4 months ago

arthurlutz commented 6 months ago

See https://github.com/esphome/esphome-docs/commit/5cc4b6769664d1e218a31e64c4cd8ea675fbfba6

eouthwaite commented 5 months ago

Hi, new to CYD but can confirm these changes work. One caveat: example 6 throws an error: Pin 25 is used in multiple places.

spi:
  - id: spi_touch
    clk_pin: GPIO25

i2s_audio:
  i2s_lrclk_pin: GPIO25

I do not know if this predates the API change, and should be a separate ticket; I couldn't see an obvious pin to change either entry to in the CYD pins documentation. Using an unused number for the audio pin "fixed" the problem.

arthurlutz commented 5 months ago

Indeed, I had to comment that out.

witnessmenow commented 4 months ago

Thanks!