witnessmenow / arduino-ifttt-maker

Arduino library for raising IFTTT maker service trigger
GNU General Public License v2.0
82 stars 18 forks source link

Incompatibilities new ArduinoJSON library #5

Open Wim3d opened 5 years ago

Wim3d commented 5 years ago

Hello, thanks for your great work. After updating to the new ArduinoJSON library I got compiling errors concerning the definition of Dynamicjsonbuffer etc. I solved my problem by downgrading to a previous version of the ArduinoJSON library

flskier commented 5 years ago

Similar issues but tried all versions of ArduinoJSON library.

Getting errors below:

"'ArduinoJson::JsonObject' has no member named 'measureLength' int length = payload.measureLength(); ^ /Documents/Arduino/libraries/IFTTTMaker/src/IFTTTMaker.cpp:82:13: error: 'ArduinoJson::JsonObject' has no member named 'printTo' payload.printTo(out); ^ Documents/Arduino/libraries/IFTTTMaker/src/IFTTTMaker.cpp: In member function 'bool IFTTTMaker::triggerEvent(String, String, String, String)': Documents/Arduino/libraries/IFTTTMaker/src/IFTTTMaker.cpp:105:3: error: 'DynamicJsonBuffer' was not declared in this scope DynamicJsonBuffer jsonBuffer;

Thanks, Andy

Wim3d commented 5 years ago

For me it works with ArduinoJSON library version 5.13.2

flskier commented 5 years ago

Thanks! That worked. This is a really useful tool. I hope that the current/future versions get updated to keep this working.

Thanks, Andy

SCKStef commented 5 years ago

The issue is still open because I use the actual json library to read my config files... There is a tutorial how to migrate to the new json library on the github page form the author, maybe you could take a look at it :-)

witnessmenow commented 5 years ago

This is not even close to being on my radar at the moment, but feel free to submit a pull request with the changes

On Sun, 28 Jul 2019, 16:07 SCKStef, notifications@github.com wrote:

The issue is still open because I use the actual json library to read my config files... There is a tutorial how to migrate to the new json library on the github page form the author, maybe you could take a look at it :-)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/witnessmenow/arduino-ifttt-maker/issues/5?email_source=notifications&email_token=AAL5PQXSV6TKUIIEVVUREBLQBWY4TA5CNFSM4FVK2572YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27AQEQ#issuecomment-515770386, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL5PQXBO3M6X67OD2FLS7TQBWY4TANCNFSM4FVK257Q .

jellewie commented 4 years ago

I can still confirm the errors occur.

Downgrading to ArduinoJson 5.X works in the meantime