search

witnessmenow / pushsafer-arduino-library

1 stars 1 forks source link

add some params and readme #2

Closed appzer closed 7 years ago

witnessmenow commented 7 years ago

Hey @appzer ! Thanks for the PR. I'm happy to merge it, but I think it's probably worth just making your fork the main one going forward as I think you will be more interested in maintaining it than I will be :)

There is a couple of things I would recommend adding (and you can base the first 2 on this library if you'd like):

  1. Support WiFi101 boards (MKR1000 and WiFi101 boards) - literally should be a case of adding new examples
  2. Travis CI build to ensure examples still work without trying them out every time you make a change - also very handy for PR
  3. If pushsafer supports http, which it sounds like it does, extend the library to support http. It should just be a case of passing in a non HTTPS client and use port 80 rather than 443. This would allow you to support ethernet shields and older wifi shields. (This is one of the most common questions I get on my other libraries!)