search

witnessmenow / spotify-api-arduino

Arduino library for integrating with the Spotify Web-API (Does not play music)
MIT License
178 stars 33 forks source link

Add define to store JSON in PSRAM #48

Closed elliotmatson closed 1 year ago

elliotmatson commented 1 year ago

I'm working on a more memory-limited application that has PSRAM, so I added a define that uses PSRAM to store JSON data

witnessmenow commented 1 year ago

Hey, thanks for the PR, the psram changes look like they are good, but I would need to be convinced about the other changes. Unless their is a major advantage to it, I don't see the reason to make the library less generic

elliotmatson commented 1 year ago

Hey, thanks for the PR, the psram changes look like they are good, but I would need to be convinced about the other changes. Unless their is a major advantage to it, I don't see the reason to make the library less generic

Ah man I'm sorry, I forgot that I had this PR open and kept committing to this fork! The PSRAM changes should be universal, and the only other one that could be helpful is the lambda functions for callbacks, that way class members can be used for callbacks.

Everything else is pretty ESP32 specific, I was hunting down an issue with downloading images, and switching to HttpClient cleared that up!