RUSTSEC-2022-0035: Unbounded memory allocation based on untrusted length

[github-actions[bot]]

Unbounded memory allocation based on untrusted length

Details
Package	websocket
Version	0.21.1
URL	https://github.com/websockets-rs/rust-websocket/security/advisories/GHSA-qrjv-rf5q-qpxc
Date	2022-08-01
Patched versions	>=0.26.5

Impact

Untrusted websocket connections can cause an out-of-memory (OOM) process abort in a client or a server. The root cause of the issue is during dataframe parsing. Affected versions would allocate a buffer based on the declared dataframe size, which may come from an untrusted source. When Vec::with_capacity fails to allocate, the default Rust allocator will abort the current process, killing all threads. This affects only sync (non-Tokio) implementation. Async version also does not limit memory, but does not use with_capacity, so DoS can happen only when bytes for oversized dataframe or message actually got delivered by the attacker.

This is a security concern for you, if

• your server application handles untrusted websocket connections
• OR your client application connects to untrusted websocket servers

Patches

The crashes are fixed in version 0.26.5 by imposing default dataframe size limits. Affected users are advised to update to this version.

Note that default memory limits are rather large (100MB dataframes and 200 MB messages), so they can still cause DoS in some environments (i.e. 32-bit). New API has been added to fine tune those limits for specific applications.

Workarounds

• Migrate your project to another, maintained Websocket library like Tungstenite.
• Accept only trusted WebSocket traffic.
• Filter the WebSocket traffic though some kind of proxy that ensures sanity limits on messages.
• Handle process aborts gracefully and limit process memory using OS tools.

Credits

This issue was reported by Evan Richter at ForAllSecure and found with Mayhem and Cargo Fuzz.

See advisory page for additional details.

[tmpolaczyk]

websocket is part of the dependency tree of the old decentralized ethereum bridge:

$ cargo tree --no-dedupe --workspace -i websocket
websocket v0.21.1
└── web3 v0.10.0
    └── witnet-ethereum-bridge v0.1.0 (/witnet-rust/bridges/ethereum)

So we can ignore this issue, or we can delete the bridges/ethereum folder because it is no longer maintained.