witnet / witnet-rust

Open source Rust implementation of the Witnet decentralized oracle protocol, including full node and wallet backend 👁️🦀
https://docs.witnet.io
GNU General Public License v3.0
179 stars 56 forks source link

feat(cli): make all stake arguments required and explicitly check validator correctness #2462

Closed drcpu-github closed 5 months ago

drcpu-github commented 5 months ago

@aesedepece Not quite sure the Default implementation I had to create for MagicEither makes a lot of sense, so a renewed review would be appreciated.

aesedepece commented 5 months ago

@aesedepece Not quite sure the Default implementation I had to create for MagicEither makes a lot of sense, so a renewed review would be appreciated.

It's a lesser evil :sweat_smile: