witoldsz / angular-http-auth

MIT License
2.37k stars 416 forks source link

bower install warning #111

Closed genuinefafa closed 8 years ago

genuinefafa commented 9 years ago

I just did a bower install (as instructed on the README.md) and it is complaining for something I don't really understand... Maybe there is a missing declaration in the json

$ bower install --save angular-http-auth
bower angular-http-auth#*   not-cached git://github.com/witoldsz/angular-http-auth.git#*
bower angular-http-auth#*      resolve git://github.com/witoldsz/angular-http-auth.git#*
bower angular-http-auth#*     download https://github.com/witoldsz/angular-http-auth/archive/v1.2.2.tar.gz
bower angular-http-auth#*      extract archive.tar.gz
bower angular-http-auth#*     mismatch Version declared in the json (1.2.1) is different than the resolved one (1.2.2)
bower angular-http-auth#* invalid-meta angular-http-auth is missing "ignore" entry in bower.json
bower angular-http-auth#*     resolved git://github.com/witoldsz/angular-http-auth.git#1.2.2
bower angular-http-auth#~1.2.2 install angular-http-auth#1.2.2
raoel commented 8 years ago

+1

Boboss74 commented 8 years ago

+1

Boboss74 commented 8 years ago

bower.json declared version 1.2.1 in the git branch tagged v1.2.2 https://github.com/witoldsz/angular-http-auth/blob/v1.2.2/bower.json

simison commented 8 years ago

@Boboss74 Bower ignores version as deprecated and relies only to git tags (https://github.com/bower/spec/blob/master/json.md#version). It was already removed: https://github.com/witoldsz/angular-http-auth/commit/7f9abe3821f7d1ab69c25c6baa1a2c48a84a1e9a

The package is missing ignore https://github.com/bower/spec/blob/master/json.md#ignore

Boboss74 commented 8 years ago

In the branch 1.2.2, there is still a version declared in the bower.json and still missing ignore entry.

So, still having on bower install

bower angular-http-auth#~1.2.2       mismatch Version declared in the json (1.2.1) is different than the resolved one (1.2.2)
bower angular-http-auth#~1.2.2   invalid-meta angular-http-auth is missing "ignore" entry in bower.json
simison commented 8 years ago

@Boboss74 Yes, these will go in only with the next version bump.

Boboss74 commented 8 years ago

Ok thanks