witoldsz / angular-http-auth

MIT License
2.37k stars 416 forks source link

Add support for CommonJS loading. #126

Closed fladi closed 7 years ago

fladi commented 8 years ago

Now that angular has CommonJS support it would be nice to have this too.

fladi commented 8 years ago

I updated this PR to add the CommonJS exports to the end of the file. Omitting typeof is not a good idea because you would get a ReferenceError if the identifier is not defined.

abobwhite commented 7 years ago

Let's get this merged...it's almost 2017!

witoldsz commented 7 years ago

Merged, released and published to npmjs.org.

abobwhite commented 7 years ago

@witoldsz Thanks for the quick action!

fladi commented 7 years ago

@witoldsz Thanks!