witoldsz / angular-http-auth

MIT License
2.38k stars 418 forks source link

Add Better loginCancelled documentation to avoid confusion #136

Closed MykhailoIskiv closed 7 years ago

MykhailoIskiv commented 8 years ago

According to source code, request will be rejected (and handled by failed callback function) only in a case of two argument are passed to it, in other case buffer just get cleared and failed callback function never executes. Please highlight it somewhere in documentation

witoldsz commented 8 years ago

I would love to see your pull request :) Thanks!