search

witoldsz / angular-http-auth

MIT License
2.38k stars 418 forks source link

Grunt uglification #139

Closed spengilley closed 7 years ago

spengilley commented 7 years ago

Minified js file

This has been tested and works great!

simison commented 7 years ago

Actually, I don't think bower modules should be serving minified files at all. See e.g.:

Esp. not from src folder; dist is a much more typical place for these.

spengilley commented 7 years ago

This is the only project I am currently using that doesn't have one. You're right though, I could uglify the code myself but this project is the odd one out currently and I wanted to bring it up to scratch in this regard with projects such as query and angularjs itself

simison commented 7 years ago

Yup, I'm not very invested in this opinion and a pragmatic way could indeed be adding minified file.

@witoldsz thoughts?

witoldsz commented 7 years ago

The idea seems really stupid, the minified version should be present in NPM Repositories, not the source code. The only problem is with Bower which I wish was never adopted by the community.

I have stopped using Bower long time ago, but I am not the only one here, so OK, the minified version will enter the Git "source" code repository. Just one question no one answered me yet: how often should we smudge the repo with updated minified file: on each commit/pull-request, on each release?

simison commented 7 years ago

on each commit/pull-request, on each release?

Release.

Edit: https://github.com/witoldsz/angular-http-auth/pull/123#issuecomment-259655558

witoldsz commented 7 years ago

Thanks @simison, just found your other answer to this a moment ago :) Will try to merge, build and release a new version today/tomorrow.

spengilley commented 7 years ago

Thanks guys :)