search

witoldsz / angular-http-auth

MIT License
2.38k stars 417 forks source link

Server error after login request #19

Closed arnoudsietsema closed 11 years ago

arnoudsietsema commented 11 years ago

I have forked the demo to demonstrate this potential bug, which can be found here: https://github.com/arnoudsietsema/angular-http-auth/tree/gh-pages

The 'server' response has a 50% chance of returning an error (http code 500). In the unauthenticated section the error shows up in the $http().error() method as expected.

For the authenticated request however something odd happens. When the error is throws after the login request was successfully executed, the $http().error () method is not called when the 500 error is returned.

Is this a bug or did I not implement this correctly?

witoldsz commented 11 years ago

Hi, thanks for your submitting this issue. The problem was the httpBuffer service ignored errors, so they were not reflected in deffered object. I have fixed this: commit 4bef6b6830c424c08d998ba2daf8ff60bb73e301.

arnoudsietsema commented 11 years ago

Thank you for the quick fix witoldsz. I've implemented your updated code and it's running perfect again.