search

witoldsz / angular-http-auth

MIT License
2.38k stars 417 forks source link

feat(bower.json): add bower.json #21

Closed 0x-r4bbit closed 10 years ago

0x-r4bbit commented 11 years ago
pauldijou commented 11 years ago

+1 for bower support, but the Angular dependency should be ">=1.0.6" since it's also working with the 1.1.x branch of Angular. Also, it would require angular-http-auth to use Git tags to version this project I think.

Regard.

0x-r4bbit commented 11 years ago

@pauldijou Never use '>=' in dependency version declaration. You'll never know if you package works with future dependencies.

witoldsz commented 11 years ago

What about versions of the angular-http-auth itself? What if one day I brake something in 'master', will it brake all the developing apps using bower and this module? Should I use branches or maybe tags with special names, so bower would pick the right one and protect developers from experiments on 'master'?

0x-r4bbit commented 11 years ago

Just Tag a stable State in your Default branch. Bower installs The latest Tag snapshot by default. Users can simply Switch between versions by specifing a Tag in Bower dependencies :)

On Saturday, June 8, 2013, Witold Szczerba wrote:

What about versions of the angular-http-auth itself? What if one day I brake something in 'master', will it brake all the developing apps using bower and this module? Should I use branches or maybe tags with special names, so bower would pick the right one and protect developers from experiments on 'master'?

— Reply to this email directly or view it on GitHubhttps://github.com/witoldsz/angular-http-auth/pull/21#issuecomment-19149574 .

/pp Sent from Gmail Mobile

ChristianKohler commented 11 years ago

+1 would be great to have bower support.

At the moment we're using a git url instead of a version number in our bower.json:

"angular-http-auth": "https://github.com/witoldsz/angular-http-auth.git"
ctjhoa commented 10 years ago

+1 too. ;)

0x-r4bbit commented 10 years ago

This one is still pending?

dv336699 commented 10 years ago

7 months later and this would be a nice addition. thanks

dv336699 commented 10 years ago

@ChristianKohler thanks for the tip.

0x-r4bbit commented 10 years ago

@diego-vieira @witoldsz what the.. still not merged?

lehmamic commented 10 years ago

+1 too and thats just the beginning :)

0x-r4bbit commented 10 years ago

HOOORAY!!! It's merged!

witoldsz commented 10 years ago

Little bit late, but here it is :) Thanks for pull-request.