witoldsz / angular-http-auth

MIT License
2.38k stars 417 forks source link

Conventional changelog #22

Closed 0x-r4bbit closed 7 years ago

0x-r4bbit commented 11 years ago

Any thoughts on my pull requests?

witoldsz commented 11 years ago

Hi, to be honest I know nothing about bower and all those modules you introduced. I am developing Java apps (and webapps since AngularJS was invented) for living. Now I know I have to learn about stuff like bower to bring an order to the front-end of the applications, but did not have time to do it yet. This is why I am not merging your changes. Not because I do not agree with them, but I cannot merge it without understanding the subject in the first place.

0x-r4bbit commented 11 years ago

Should I explain to you? :) the bower.json is there, so that you can simply do $ bower install to install all dependencies this project has. In addition to that, it is required, to register this project in the bower registry as a bower package, so that others are able to install angular-http-auth via:

$ bower install angular-http-auth

That's definitely a win-win! :)

The grunt-conventional-changelog is a tool to generate change automatically :) Every project shoud have it!

revolunet commented 11 years ago

+1

eddiemonge commented 10 years ago

@witoldsz if @PascalPrecht is suggesting something, its probably amazing and good.

khasinski commented 10 years ago

+1 for bower, we already use it in Espeo in a few projects. Some of them could use angular http auth.

witoldsz commented 10 years ago

I am not sure about this conventional-changelog thing. Do we really need this for such a small project like this?

0x-r4bbit commented 10 years ago

Not necessary, but it doesn't hurt :)

alonisser commented 10 years ago

:+1:

jameskleeh commented 10 years ago

+1

maxwellium commented 10 years ago

+1 for bower; grunt-changelog not necessarily. since a good bower.json will bring more exposure to this repo, it might attract a lot more contributors ;)

witoldsz commented 10 years ago

bower has been added year ago

maxwellium commented 10 years ago

ha neat ! I still had the git in my bower ;)

simison commented 7 years ago

@witoldsz I think this can be closed already, see: #21 #139