Closed 0x-r4bbit closed 7 years ago
Hi, to be honest I know nothing about bower and all those modules you introduced. I am developing Java apps (and webapps since AngularJS was invented) for living. Now I know I have to learn about stuff like bower to bring an order to the front-end of the applications, but did not have time to do it yet. This is why I am not merging your changes. Not because I do not agree with them, but I cannot merge it without understanding the subject in the first place.
Should I explain to you? :) the bower.json
is there, so that you can simply do $ bower install
to install all dependencies this project has. In addition to that, it is required, to register this project in the bower registry as a bower package, so that others are able to install angular-http-auth
via:
$ bower install angular-http-auth
That's definitely a win-win! :)
The grunt-conventional-changelog
is a tool to generate change automatically :) Every project shoud have it!
+1
@witoldsz if @PascalPrecht is suggesting something, its probably amazing and good.
+1 for bower, we already use it in Espeo in a few projects. Some of them could use angular http auth.
I am not sure about this conventional-changelog
thing. Do we really need this for such a small project like this?
Not necessary, but it doesn't hurt :)
:+1:
+1
+1 for bower; grunt-changelog not necessarily. since a good bower.json will bring more exposure to this repo, it might attract a lot more contributors ;)
bower has been added year ago
ha neat ! I still had the git in my bower ;)
@witoldsz I think this can be closed already, see: #21 #139
Any thoughts on my pull requests?