witoldsz / angular-http-auth

MIT License
2.37k stars 416 forks source link

$http.defaults.headers.common? #59

Open saturation opened 10 years ago

saturation commented 10 years ago

I am not sure if this issue at all but something to discuss atleast.

What is the case of $http.defaults.headers.common? I put my auth-token in there on successful login, then auth-interceptor replies failed xhrs but that auth-tokens is not there.

Of course because of this authentication failes again in backend so login will pop up again..

So should these $http.defaults.headers.common -headers always add on the top of the config?

function retryHttpRequest(config, deferred) {
    function successCallback(response) {
      deferred.resolve(response);
    }
    function errorCallback(response) {
      deferred.reject(response);
    }
    $http = $http || $injector.get('$http');
    $http(config).then(successCallback, errorCallback);
  }

or how this case should be handled?

witoldsz commented 10 years ago

I am sure it there was discussion about the issue here some time ago...

alexbonhomme commented 8 years ago

Hello there,

I'm facing the exact same problem during a refreshing access token (using refresh token). When I udpates the $http.defaults.headers.common.Authorization the Authorization header of the request isn't updated. I'm looking for a "more global" solution, but currently I only knows the solution propose in the README

If you have figure out a better solution please keep me in touch :)