search

witoldsz / angular-http-auth

MIT License
2.38k stars 417 forks source link

Support for commonJS syntax #92

Closed jgoux closed 7 years ago

jgoux commented 9 years ago

Could you consider adding support for commonJS so we can install angular-http-auth with NPM ? The work is already done in forks like this one : https://github.com/twalling/angular-http-auth

witoldsz commented 9 years ago

I'll take a look at it soon.

witoldsz commented 9 years ago

The "angular-http-auth" is now available as an npm package. I am not sure about CommonJS though. Is that a one-way ticket? What if someone use RequireJS or yet something else?

petermetz commented 8 years ago

@witoldsz There are solutions for supporting multiple module formats, details explained here and here

Obviously it's a way street in the sense that if you opt to support any module format and later on what to remove the support, then you'll have some people complaining that they are stuck on older versions.

Other than that, I personally don't see any risk in adding support for any of the module formats at all.

simison commented 7 years ago

PR: #126

witoldsz commented 7 years ago

Merged, released and published to npmjs.org.