search

wittlock / ngx-image-zoom

Angular component for zoomable images
https://wittlock.github.io/ngx-image-zoom/
MIT License
134 stars 64 forks source link

Feat alt title #105

Closed mustafapsd closed 2 years ago

mustafapsd commented 2 years ago

Feature for https://github.com/wittlock/ngx-image-zoom/issues/91

wittlock commented 2 years ago

This looks good at a glance. Thanks for tidying up the code a bit as well. Another thing I've just never gotten around to. I just want to test run it a little before merging but hopefully tomorrow or Monday I should be able to do that, I'm currently traveling without a computer.

Two things though, is it really worth it to add the alt and title to the large image as well? And would you mind updating the Readme and changelog with these new features too?

wittlock commented 2 years ago

This looks good at a glance. Thanks for tidying up the code a bit as well. Another thing I've just never gotten around to. I just want to test run it a little before merging but hopefully tomorrow or Monday I should be able to do that, I'm currently traveling without a computer.

Two things though, is it really worth it to add the alt and title to the large image as well? And would you mind updating the Readme and changelog with these new features too?

mustafapsd commented 2 years ago

If this package will be compatible with SSR, then that will be worth it. I will take a look at README and CHANGELOG. I will do it tomorrow. Have a nice day!