search

wittlock / ngx-image-zoom

Angular component for zoomable images
https://wittlock.github.io/ngx-image-zoom/
MIT License
134 stars 64 forks source link

Add safeurl #128

Closed r0754497 closed 1 year ago

r0754497 commented 1 year ago

Add SafeUrl compatibility for easy piping.

r0754497 commented 1 year ago

Actually one issue with it found during testing. Adding a commit to fix it soon.

r0754497 commented 1 year ago

Done. Added | null because sanitizer can return null. Don't seem to be any serious issues when the image is null.

wittlock commented 1 year ago

It does irk me a tiny bit that null is a listed type for thumbimage since it's mandatory for the library to do anything. But I think the convenience of it outweighs it.