Image tag is changed to picture tag

wittlock / ngx-image-zoom

Angular component for zoomable images

https://wittlock.github.io/ngx-image-zoom/

MIT License

134 stars 64 forks source link

Image tag is changed to picture tag #143

Open garybarzola opened 12 months ago

garybarzola commented 12 months ago

The picture tag is currently compatible with all browsers and allows progressive image loading according to the available internet conditions and screen sizes.

danigandarillas commented 11 months ago

Great, really good solution and upgrade. It will help a lot!

ernestoliberio commented 11 months ago

This should be in the repo as a feature @wittlock

wittlock commented 11 months ago

I'm not personally familiar with the picture tag and it's compatibility. It seems fairly well adapted looking at caniuse.com - but I'd be a bit worried swapping a core tag like this out just like that. Could this maybe be adjusted to be an alternative template with an opt-in setting to use it?

garybarzola commented 10 months ago

Of course it works just as you describe, that's the great thing about this picture tag. I have added two alternative inputs: thumbImageSource and fullImageSource, which if added would complete the functionality of the picture tag and if not added would work as it has been working with the thumbImage and fullImage inputs.

@wittlock