wittlock / ngx-image-zoom

Angular component for zoomable images
https://wittlock.github.io/ngx-image-zoom/
MIT License
133 stars 64 forks source link

Image tag is changed to picture tag #143

Open garybarzola opened 1 year ago

garybarzola commented 1 year ago
danigandarillas commented 1 year ago

Great, really good solution and upgrade. It will help a lot!

ernestoliberio commented 1 year ago

This should be in the repo as a feature @wittlock

wittlock commented 1 year ago

I'm not personally familiar with the picture tag and it's compatibility. It seems fairly well adapted looking at caniuse.com - but I'd be a bit worried swapping a core tag like this out just like that. Could this maybe be adjusted to be an alternative template with an opt-in setting to use it?

garybarzola commented 1 year ago

Of course it works just as you describe, that's the great thing about this picture tag. I have added two alternative inputs: thumbImageSource and fullImageSource, which if added would complete the functionality of the picture tag and if not added would work as it has been working with the thumbImage and fullImage inputs.

@wittlock