wiverson / maven-jpackage-template

Sample project illustrating building nice, small cross-platform JavaFX or Swing desktop apps with native installers while still using the standard Maven dependency system.
Apache License 2.0
351 stars 53 forks source link

MAVEN_OPTS="--add-modules jdk.incubator.jpackage" not working on windows #2

Closed o4codes closed 3 years ago

o4codes commented 3 years ago

adding MAVEN_OPTS="--add-modules jdk.incubator.jpackage" to env on windows does not yield appropriate results when mvn --version is ran. this is what it produces as output on windows:

Unrecognized option: --add-modules jdk.incubator.jpackage Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit.

How can this be solved ?

wiverson commented 3 years ago

What is the output of running java --version at the command line?

wiverson commented 3 years ago

Was able to repro. Don't put the --add-modules jdk.incubator.jpackage inside of quotes in the Windows env variable pane.

mvn opts for windows
wiverson commented 3 years ago

Let me know if this works. If not, feel free to reopen.

o4codes commented 3 years ago

Thanks. This works