wiverson / maven-jpackage-template

Sample project illustrating building nice, small cross-platform JavaFX or Swing desktop apps with native installers while still using the standard Maven dependency system.
Apache License 2.0
338 stars 51 forks source link

MSI update don't work #71

Open ddark008 opened 1 year ago

ddark008 commented 1 year ago

New msi with bump app.version with same UUID in pom.xml doesn't upgrade previous, it's install like new. Look like bad wix configuration. For test propose add to windows-jpackage.txt argument: "--win-dir-chooser"

Links for research:

  1. https://wixtoolset.org/documentation/manual/v3/howtos/updates/major_upgrade.html
  2. https://blog.codeinside.eu/2012/12/13/windows-installer-xml-wix-and-version-numbers-what-is-important-and-what-isnt/
  3. https://docs.oracle.com/en/java/javase/17/jpackage/override-jpackage-resources.html#GUID-62412365-821D-4736-A20D-70F2D47136D8
  4. https://stackoverflow.com/questions/67159129/how-to-override-javas-jpackage-wix-defaults-to-create-an-environment-variable-c
  5. https://stackoverflow.com/questions/10517066/wix-how-to-override-upgradecode-when-installing-an-msi-file
wiverson commented 1 year ago

So, FWIW there were some issues around timestamps being used for upgrade versions in the earlier version of this template. In certain circumstances a timestamp was going backwards instead of fowards.

I just redid the way versions work to build on top of GitHub Action run ids instead of timestamps. I think this is closer to what everyone wants:

RE: the install like new vs upgrade, is this a bug in jpackage or the template...?