search

wix-incubator / DetoxSync

Synchronization framework for Detox and other testing frameworks
MIT License
34 stars 16 forks source link

DetoxSync: add fishhook as submodule. #12

Closed asafkorem closed 3 years ago

asafkorem commented 3 years ago

Depends on https://github.com/wix/DTXObjectiveCHelpers/pull/2.

asafkorem commented 3 years ago

As for DTXObjectiveCHelpers' commit - better to use 1f1b380775f604c61ec4eb8584df40f1d8487291 (i.e. the one generated in master following the merge).

Good point, doing it :+1:

@asafkorem seems that the submodule, though named DTXSwizzlingHelper, is in fact wired to DTXObjectiveCHelpers as its remote. Would you consider a rename?

That's true, I thought about this too, but I generally think that we should migrate all these sub-projects into the main project repo. Anyway, until then, I agree that it would be better to rename it. I'll do this.

d4vidi commented 3 years ago

I see your point 🆗

asafkorem commented 3 years ago

Done 🙂