search

wix-incubator / accord

Accord: A sane validation library for Scala
http://wix.github.io/accord/
Other
529 stars 55 forks source link

accord-api should only depend on scalatest in test scope? #108

Closed cwei-bgl closed 7 years ago

cwei-bgl commented 7 years ago

Hi, Thanks for the library.

I got conflicts between my scalatest 3.x dependency and scalatest 2.2.6 which accord-api brings in. The conflicts can be easily resolved by exclusion. I just wonder if accord-api should only depend on scalatest in test scope?

Thanks, Cheng

holograph commented 7 years ago

I've been wondering about that. I don't really have an opinion on the matter, so yours wins :-) I'll sort it out for next version.

holograph commented 7 years ago

Wait, what? I misread your bug report and thought you meant the accord-scalatest module. accord-api strictly brings in ScalaTest as a test dependency, i.e. that should not propagate to your own project. Maybe you are doing something funny with your build script?

rfranco commented 7 years ago

I have the same issue, for some reason accord-api depends on scalatest

[info]   +-com.wix:accord-core_2.11:0.6.1 [S]
[info]   | +-com.wix:accord-api_2.11:0.6.1 [S]
[info]   | | +-org.scalatest:scalatest_2.11:2.2.6 [S]
[info]   | |   +-org.scala-lang.modules:scala-xml_2.11:1.0.2 [S]
[info]   | |   +-org.scala-lang:scala-reflect:2.11.9 [S]
holograph commented 7 years ago

Ah yes, this is a duplicate of #97 (which also includes a workaround until the next version is out). This is basically me being stupid...

holograph commented 7 years ago

For reference, the workaround is adding an exclusion to the dependency:

libraryDependencies += "com.wix" %%% "accord-core" % "0.6.1" excludeAll(ExclusionRule(organization = "org.scalatest"))