search

wix-incubator / angular-tree-control

Angular JS Tree
http://wix.github.io/angular-tree-control
MIT License
708 stars 276 forks source link

No minified versions of JS / CSS in bower package #113

Open drew-r opened 9 years ago

drew-r commented 9 years ago

Pretty self explanatory really :) Would be great to get one included in the bower package.

yoavaa commented 9 years ago

To my understanding, bower guidelines are that minified versions should not be included in package. Rather, you should create your versions in your build process. On Mar 9, 2015 1:26 AM, "Drew R" notifications@github.com wrote:

Pretty self explanatory really :) Would be great to get one included in the bower package.

— Reply to this email directly or view it on GitHub https://github.com/wix/angular-tree-control/issues/113.

drew-r commented 9 years ago

Bower spec does say this but almost all widely used libraries include one for convenience... JQuery, AngularJS, Blanket, Bootstrap, D3.js etc.

On Sun, Mar 8, 2015 at 11:39 PM, Yoav Abrahami notifications@github.com wrote:

To my understanding, bower guidelines are that minified versions should not be included in package. Rather, you should create your versions in your build process. On Mar 9, 2015 1:26 AM, "Drew R" notifications@github.com wrote:

Pretty self explanatory really :) Would be great to get one included in the bower package.

— Reply to this email directly or view it on GitHub https://github.com/wix/angular-tree-control/issues/113.

— Reply to this email directly or view it on GitHub https://github.com/wix/angular-tree-control/issues/113#issuecomment-77782341 .

Kepro commented 8 years ago

That's been discussed multiple times on the issue tracker, and the consensus is that JS in Bower packages should be built, but not minified. The simple reason being that most will minify them in their build step anyways, and having both bloats the package and complicates everything.

drew-r commented 8 years ago

@Kepro I call copypasta

MichaelFroeschen commented 6 years ago

Since bower is deprecated now, i think it is time to move on from this (IMHO) stupid rule. This is the only dependency i have, that needs to be minified by my build process.

Not providing a minified version leads to bloated build processes and possible problems for the users