search

wix-incubator / angular-tree-control

Angular JS Tree
http://wix.github.io/angular-tree-control
MIT License
707 stars 276 forks source link

https://github.com/wix/angular-tree-control/issues/214 #215

Closed destromas1 closed 8 years ago

yoavaa commented 8 years ago
  1. The tests are failing, so we cannot merge.
  2. you changed the interface of external API functions like defaultEquality - and I'd rather not do that as it is a breaking change. Adding the $scope parameter as the first parameter of the function is a breaking change.
destromas1 commented 8 years ago

@yoavaa Yes I saw the Test is failing after my change . Then I reverted my code and tried to run test but Test was failing then also . Can u plz check on the master branch that Test passes or fails ?

yoavaa commented 8 years ago

it is working in master. Just checked.

The reason it fails is because the equality function used to accept (a,b) and now accepts (scope,a,b). If the default quality will get (a,b,scope) instead of (scope,a,b) it will be backward compatible.

On Mon, May 2, 2016 at 10:04 AM Shahjada Talukdar notifications@github.com wrote:

@yoavaa https://github.com/yoavaa Yes I saw the Test is failing after my change . Then I reverted my code and tried to run test but Test was failing then also . Can u plz check on the master branch that Test passes or fails ?

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/wix/angular-tree-control/pull/215#issuecomment-216119732

destromas1 commented 8 years ago

@yoavaa I will make the changes and push!

destromas1 commented 8 years ago

@yoavaa Test passes now . Please merge ! Thanks!