search

wix-incubator / angular-tree-control

Angular JS Tree
http://wix.github.io/angular-tree-control
MIT License
708 stars 277 forks source link

A rocover fix for the deep circular object 'Maximum call stack size e… #241

Open ehsankhf opened 8 years ago

ehsankhf commented 8 years ago

This is an error rocovery fix for the deep circular object 'Maximum call stack size exceeded' error for angular.equals in defaultEquality function.

In some cases with deep circular object it still gives error which is probably caused by the equivalence of two object in the shallow levels and more comparisons in the deep levels.

ehsankhf commented 8 years ago

In reality in many cases we don't need to compare deep levels, so the fix works in most cases. I think it should be warned for those who are using this plugin with many nodes and very deep levels.