wix-incubator / angular-tree-control

Angular JS Tree
http://wix.github.io/angular-tree-control
MIT License
707 stars 276 forks source link

0.2.30 Crashes Hard #285

Open mike-ward opened 6 years ago

mike-ward commented 6 years ago

Been using this control for several years and really like it. However, upgrading from 0.2.28 to 0.2.30 crashes my app. I'm not getting any feedback in the console. My app simply doesn't load. This is usually indicative of a null reference to an expected object. Wish I had more but I'm on a deadline right now.

Running AngularJS 1.6.9, any browser reproduces the issue.

yoavaa commented 6 years ago

Did you include the context-menu.js file? we have merged a pull request a few days ago that added this support.

@stueynz can you have a look?

frame commented 6 years ago

Not sure if related. When I use 0.2.30 with context-menu.js, I get the following exception:

[$injector:strictdi] function(e) is not using explicit annotation and cannot be invoked in strict mode

When I revert back to 0.2.28, everything works again. My apologies if this comment isn't related to the crash OP reported.

Zorkeel commented 6 years ago

Hi,

Same problem here since last update. The angular App won't build, and I have this error in the console:

Error: [$injector:modulerr] Failed to instantiate module app due to:
[$injector:modulerr] Failed to instantiate module treeControl due to:
[$injector:modulerr] Failed to instantiate module contextMenu due to:
[$injector:nomod] Module 'contextMenu' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
http://errors.angularjs.org/1.6.9/$injector/nomod?p0=contextMenu
minErr/<@http://localhost:3043/build/bundle.js:71596:12
module/<@http://localhost:3043/build/bundle.js:73783:17
ensure@http://localhost:3043/build/bundle.js:73704:38
module@http://localhost:3043/build/bundle.js:73781:14
loadModules/<@http://localhost:3043/build/bundle.js:76479:22
forEach@http://localhost:3043/build/bundle.js:71888:11
loadModules@http://localhost:3043/build/bundle.js:76463:5
loadModules/<@http://localhost:3043/build/bundle.js:76481:40
forEach@http://localhost:3043/build/bundle.js:71888:11
loadModuleā€¦

I've checked, the context-menu.js file is present in the node_modules\angular-tree-control\ folder.

frame commented 6 years ago

@Zorkeel: You also need to include context-menu.js via Githubissues.

  • Githubissues is a development platform for aggregating issues.