search

wix-incubator / corvid-types

Type definitions for Corvid by Wix
MIT License
5 stars 3 forks source link

feat(json-n-jsw): support typings for jsw and json files #43

Closed matanlb closed 4 years ago

nemni8 commented 4 years ago

good work! I think you should split your changes into smaller commits (revert old JSON solution, eslint rule, implement JSON, implement jsw, test). please wait with the merge, I know that @dor-itzhaki wanted to go over it before you merge this code.

matanlb commented 4 years ago

good work! I think you should split your changes into smaller commits (revert old JSON solution, eslint rule, implement JSON, implement jsw, test). please wait with the merge, I know that @dor-itzhaki wanted to go over it before you merge this code.

Thanks :) I'll wait for @dor-itzhaki review. Regarding splitting the PR. That might have been a good idea before I started working on this, but since I've been working on both the JSON and JSW for a while now I see how similar they are so inlight of the amount of changes needed does't make much since to me to split them. As far as the eslint go's, that's just a happy accident I had to fix it :)

matanlb commented 4 years ago

can you please split the refactor of the dynamic typings from the jsw solution ? i'm losing myself and can't really review it this way...

@dor-itzhaki I can but only downstream from this branch not off master