search

wix-incubator / corvid-types

Type definitions for Corvid by Wix
MIT License
5 stars 3 forks source link

feat(crvd-3379): support for custom files #52

Closed matanlb closed 3 years ago

nemni8 commented 3 years ago

imo we should build 2 versions of corvid types regular and with custom services. then in order to get the new types, we will just need to import the "new" bundle of corvid-types

matanlb commented 3 years ago

@nemni8 quite a change you made me do 😅 but the more I've worked on it the more I saw it was super necessary

I've tried to keep the custom-types mass as localised as I could but I had not choice but to split the index file to create a separate bundle without duplicating the code.

Testing wise we CAN tests, we can just import the build artefact like the normal types and run the same suite for it too. Only issue is that without converting the entire wix-data declaration file the tests file. (also there is an issue with wix-router having a small usage of wix_data.WixDataQuery that we'll need to solve) but I think we'll tackle this when we're back on this wix-data-autocomplete project. Until then we know that when we get to experiment stage we can have the tests run for these on every build once we decide to pull the trigger.

I know we're taking a pause from this but I'd really like to leave a clean env before we move on, so please try and re-review this :)